Skip to content

Conversation

@fatih-acar
Copy link
Contributor

@fatih-acar fatih-acar commented Oct 15, 2025

Same as #7327 but in a separate PR as it depends on a SDK update.

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced SSL/TLS verification for client connections to ensure secure encrypted communication with backend services.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Oct 15, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The change modifies the InfrahubClient initialization in the dependencies module to include SSL/TLS verification. A Config object is constructed with the existing address and retry_on_failure parameters, then an SSL context is configured by calling set_ssl_context() with the result of get_http().verify_tls(). The InfrahubClient is then instantiated with this updated configuration. The remainder of the client initialization process and schema caching logic remains unmodified.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fac-tls-context-sdk-client

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6fa4ca and 9280e1b.

📒 Files selected for processing (1)
  • backend/infrahub/workers/dependencies.py (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 15, 2025

CodSpeed Performance Report

Merging #7396 will not alter performance

Comparing fac-tls-context-sdk-client (9280e1b) with release-1.5 (e6fa4ca)

Summary

✅ 10 untouched

@fatih-acar fatih-acar force-pushed the fac-fix-ssl-contexts branch from 820eb29 to f5b5c77 Compare October 30, 2025 12:35
@fatih-acar fatih-acar force-pushed the fac-tls-context-sdk-client branch from 2b54551 to eb02b6f Compare October 30, 2025 13:24
Base automatically changed from fac-fix-ssl-contexts to stable October 31, 2025 12:07
@fatih-acar fatih-acar force-pushed the fac-tls-context-sdk-client branch from eb02b6f to 9280e1b Compare November 3, 2025 12:41
@fatih-acar fatih-acar changed the base branch from stable to release-1.5 November 3, 2025 12:41
@fatih-acar fatih-acar marked this pull request as ready for review November 3, 2025 13:16
@fatih-acar fatih-acar requested a review from a team as a code owner November 3, 2025 13:16
@fatih-acar fatih-acar merged commit dbabb80 into release-1.5 Nov 3, 2025
35 checks passed
@fatih-acar fatih-acar deleted the fac-tls-context-sdk-client branch November 3, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants